Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid getattr when dispatching pytest_runtest_* hooks #6743

Merged
merged 2 commits into from
Feb 15, 2020
Merged

Avoid getattr when dispatching pytest_runtest_* hooks #6743

merged 2 commits into from
Feb 15, 2020

Conversation

bluetech
Copy link
Member

Using getattr doesn't work with typing, and also breaks grep. It took me a while to find where these hooks are called.

@bluetech
Avoid getattr when dispatching pytest_runtest_* hooks
371939f 
Using getattr doesn't work with typing, and also breaks grep. It took me
a while to find where these hooks are called.
blueyed
blueyed approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

src/_pytest/runner.py Show resolved Hide resolved
@bluetech bluetech merged commit 959e6b4 into pytest-dev:master Feb 15, 2020
@bluetech bluetech deleted the runtest-getattr branch February 28, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueyed blueyed blueyed approved these changes

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluetech @blueyed @nicoddemus