ENH: forbid delete attr from frozen class #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise FrozenInstanceError when trying to delete an attribute from a frozen class.
Current coverage is 100% (diff: 100%)@@ master #118 diff @@
====================================
Files 8 8
Lines 502 505 +3
Methods 0 0
Messages 0 0
Branches 110 110
====================================
+ Hits 502 505 +3
Misses 0 0
Partials 0 0
|
|
This makes sense. Would you please add a changelog entry? |
|
Sorry that took so long. Went for 'change' not 'API break'. |
|
Thanks! I’m fixed it myself but next time use semantic line feeds please. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise FrozenInstanceError when trying to delete an attribute from
a frozen class.
On non-frozen classes
delresults in un-shadowing theattr.ibobject which is a bit surprising.