Added composite validator.
#183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2017 20:18
DRY by combining existing validators.
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 546 558 +12
Branches 121 124 +3
=====================================
+ Hits 546 558 +12
Continue to review full report at Codecov.
|
|
I think that use case is already handled by 17.1’s support for passing lists for validators aka #138? (yes, I really need to get 17.1 out :'() |
|
Yep, you're right, passing a list to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
first of all thank you for attrs, it's truly a joy to use.
I just wanted to contribute this composite validator I wrote that's been useful for me, hopefully it makes sense for you too.
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
.rstfiles is written using semantic newlines.versionadded,versionchanged, ordeprecateddirectives.CHANGELOG.rst.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!