Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

450 kwonly before init false #459

Merged
merged 8 commits into from
Nov 24, 2018

Conversation

gabbard
Copy link
Member

@gabbard gabbard commented Oct 31, 2018

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

  • [ X] Added tests for changed code.
  • [ X] New features have been added to our Hypothesis testing strategy. (Wasn't obvious what to add, if anything)
  • [X ] Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • [X ] ...and used in the stub test file tests/typing_example.py. No changes to public APIs
  • [ X] Updated documentation for changed code. n/a
    • [ X] New functions/classes have to be added to docs/api.rst by hand.
    • [ X] Changes to the signature of @attr.s() have to be added by hand too.
    • [ X] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
  • [ X] Documentation in .rst files is written using semantic newlines. no docs added
  • [X ] Changes (and possible deprecations) have news fragments in changelog.d.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

@hynek
Copy link
Member

hynek commented Nov 3, 2018

I’m at a conference so I can’t review in depths. It looks good overall, but could you make sure that attr.ib(init=False, default=42) works too?

@gabbard
Copy link
Member Author

gabbard commented Nov 5, 2018

@hynek : thanks - I've added the requested test

Copy link
Member

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s a bit of minor stuff (changeling is not markdown;)) but I made you wait long enough, I’m very sorry!

@hynek hynek merged commit e114561 into python-attrs:master Nov 24, 2018
@gabbard gabbard deleted the 450-kwonly-before-init-false branch November 26, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants