Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of distutils.msvc9compiler #120

Closed
wants to merge 1 commit into from

Conversation

dpaoliello
Copy link

distutils.msvc9compiler has been deprecated for a while, and has recently been removed, which breaks cffi on Windows.

This change:

  • Removes the use of distutils.msvc9compiler.
  • Removes the _remove_visual_c_ref workaround, as it's no longer required for setuputils.
  • Changes test_ownlib to use the CCompiler API directly instead of manually running cl.exe.
  • Fixes test failures:
    • zdistutil wasn't generating unique file names, as the first 10 characters of the test names were the same.
    • empty-test needs to export the function on Windows.

Fixes #117

@dpaoliello
Copy link
Author

This was fixed by #118

@dpaoliello dpaoliello closed this Sep 20, 2024
@dpaoliello dpaoliello deleted the msvc branch September 20, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cffi relies on deprecated (now removed) distutils.msvc9compiler module
2 participants