Fix #20 - nullable semantics with $ref, oneOf, anyOf, and allOf #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
==========================================
- Coverage 78.03% 77.51% -0.52%
==========================================
Files 6 6
Lines 264 258 -6
Branches 41 40 -1
==========================================
- Hits 206 200 -6
Misses 47 47
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Re-implemented nullable based on OAS 3.0.3 definition. |
p1c2u
approved these changes
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for the fantastic work on a schema validator. This project has helped me significantly in validating dynamically generated openapi schemas.
Please consider merging this small improvement in handling nullable behavior.
The root of #20 seems to be that if a schema node is a meta node ($ref, allOf, anyOf, or oneOf), nullable shouldn't be checked.
The tests added validate both that null is allows when nullable:true the destination schema, and not allowed when nullable:false is on the destination schemas.