CI: Update Cygwin NumPy to 1.26 in Python 3.9 #7875
Conversation
Cygwin has Netlib interfaces, NumPy CI uses them. Let's see if we can force pip/meson to use them.
New NumPy uses CMake through meson, which needs dependencies.
Ah, ok, you mean that the PR pinned NumPy on Cygwin, and this removes the pinning. Normally, I would only think of issues as being "fixed", not PRs that passed and were merged. |
Necessary with version constraint, not without. Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
changed the title
|
I've updated the PR title, as this only affects Python 3.9 - NumPy 1.24 is the last version to support Python 3.8, so this makes no difference for 3.8. |
|
It turns out there is a problem, both in this PR and in main, and for both Python 3.8 and 3.9 - NumPy is not detected by the tests. |
The tests can't find it, so check here.
There's a decent chance the cygwin/cygwin-install-action paths in egor-tensin/cleanup-path broke numpy import, since NumPy needs to find BLAS somewhere.
|
Looks like the switch to the egor-tensin Cygwin install action didn't catch all the places the default install path got used: in particular, the egor-tensin/cleanup-path specification of the new path, including the location of the BLAS and Lapack runtimes. In any case, it looks like 3.8 and 3.9 are finding NumPy now. |
It's working again, so this isn't relevant anymore. Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
I've created #7880 as an alternative to this. |
|
We've merged #7880, but thanks for this PR that prompted that one :) |
Removes the NumPy-pinning requirement noted in #7403.
Changes proposed in this pull request:
liblapack-devel. NumPy recently changed how to specify BLAS versions: reference here and elaboration here. Pip can pass arguments through to sub-processes. Combining those, it should be possible to allow CI to use the most recent NumPy version. This is a slight tweak of the fix proposed in NumPy now supports Python 3.12 #7403.