Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winbuild: Build freetype.vcxproj to fix passing in custom parameters #8403

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Sep 22, 2024

#8302 broke passing in custom properties to FreeType, fix it by using the VS project file directly instead of the solution file.

This should fix the skipped CBDT/SBIX/WOFF2 tests.

@nulano nulano changed the title winbuild: Build freetype.vcxproj to fix passing in custom parameters. winbuild: Build freetype.vcxproj to fix passing in custom parameters Sep 22, 2024
@nulano
Copy link
Contributor Author

nulano commented Sep 22, 2024

An alternative would be to pass in the custom parameters to the MSBuild.sln using command line parameters in /p:UserDefines="..." format, but that causes the command to be really long, and I am not convinced it is easier to read.

@radarhere radarhere merged commit e179d04 into python-pillow:main Sep 23, 2024
65 of 66 checks passed
@nulano nulano deleted the freetype-fix branch September 23, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants