-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recalculate python markers on dependency more often #284
recalculate python markers on dependency more often #284
Conversation
f3596c5
to
9ac4ebe
Compare
now including a proposed fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I wonder if it may break some code that exploited the current behavior (as in the case of the pretty_constraint fix). Nevertheless, seems to be correct anyway and since all tests are passing, I think it could be merged.
Updating a marker in a way that removes python version constraints fails to remove the python version constraint
... when updating the marker
d3b11de
to
4bb8320
Compare
(rebased to resolve conflicts after other MRs were merged) |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Updating a marker in a way that removes python version constraints fails to remove the python version constraint
Not for merging, until there's a fix! This is a demonstration of "bug 2" per python-poetry/poetry#5154