Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize extras per PEP685 #476

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

dimbleby
Copy link
Contributor

https://peps.python.org/pep-0685/#specification says both that all comparisons should be done with normalized extra names, and that normalized extra names should be written to metadata.

Simplest and surest approach seems to be just to deal with normalized names everywhere.

Fixes python-poetry/poetry#6321.

will cause CI failures in the downstream tests because poetry now records normalized extra names in lockfiles. I think that's correct and will follow up with a poetry MR to fix the unit tests against this.

However this presents some poetry / poetry-core challenges re merge order and version numbering. As in other MRs, I'd advocate for allowing such things and being comfortable going 2.0 here - though even then the cross-repository pipelines want some disentangling.

@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@radoering radoering merged commit 0ee61e2 into python-poetry:main Oct 3, 2022
@radoering
Copy link
Member

@dimbleby Please don't delete your branch until we don't depend on it in poetry anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poetry doesn't install extra dependencies when the extra is capitalised
2 participants