Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect metadata_directory #487

Merged
merged 3 commits into from
Nov 18, 2022

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Oct 2, 2022

Fixes python-poetry/poetry#1078

I'm not sure how useful this really is, but it seems to be what the spec asks for.

It should anyway be an improvement on the half-hearted existing implementation which:

  • provided prepare_metadata_for_build_wheel() but then didn't respect metadata_directory in build_wheel()
  • duplicated code (but not fully, ie there was divergence between the two metadata-building places)

It might have been even simpler just to remove prepare_metadata_for_build_wheel() altogether - it's not mandatory - but whatever.

pip wheel . executes this code path: that this works is perhaps a more convincing proof that the MR is OK than the unit test.

Change in file permission unit test is because I now see these files getting 100644 rather than just 644. Not entirely sure why that has changed but it seems benign so I've allowed it.

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@neersighted neersighted enabled auto-merge (squash) November 18, 2022 20:36
@neersighted neersighted merged commit 24cb523 into python-poetry:main Nov 18, 2022
@dimbleby dimbleby deleted the metadata-directory branch November 18, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry.masonry.api.build_wheel disregards metadata_directory
2 participants