Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optional output directory for building #527

Conversation

AdamWRichardson
Copy link
Contributor

@AdamWRichardson AdamWRichardson commented Nov 24, 2022

This PR makes it possbile for the builder factory class to accept an optional output directory when building packages. This builder factory is used by the command line and if this is accepted I would like to add an extra option to the command line to allow placing build artifacts in a directory other than dist.

Of course I am happy to take comments and feedback.

Relates-to: python-poetry/poetry#3586

@AdamWRichardson AdamWRichardson requested review from finswimmer and radoering and removed request for finswimmer and radoering December 5, 2022 09:18
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to mimic the src folder structure and put the test into tests/masonry/test_builder.py.

tests/masonry/builders/test_builder_factory.py Outdated Show resolved Hide resolved
tests/masonry/builders/test_builder_factory.py Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.2% 5.2% Duplication

@radoering radoering enabled auto-merge (squash) January 7, 2023 16:00
@radoering radoering merged commit af98abc into python-poetry:main Jan 7, 2023
@radoering radoering mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants