markers: add new method to reduce a marker by a Python constraint #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
radoering
force-pushed
the
markers/reduce-by-python-constraint
branch
from
ec280ef
to
c4773a8
Compare
radoering
force-pushed
the
markers/reduce-by-python-constraint
branch
from
c4773a8
to
e75e42d
Compare
edgarrmondragon
approved these changes
Jul 2, 2024
radoering
force-pushed
the
markers/reduce-by-python-constraint
branch
from
e75e42d
to
8b1f2cc
Compare
Secrus
approved these changes
Jul 28, 2024
That is useful for removing redundant information from markers. For example, if the project's Python constraint is `>=3.9`, a dependency's marker like `python_version >= 3.7` carries the same information as an `AnyMarker` for this project. (The dependency is required for all supported Python versions.)
radoering
force-pushed
the
markers/reduce-by-python-constraint
branch
from
8b1f2cc
to
c3b86d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is useful for removing redundant information from markers. For example, if the project's Python constraint is
>=3.9, a dependency's marker likepython_version >= 3.7carries the same information as anAnyMarkerfor this project. (The dependency is required for all supported Python versions.)Required for python-poetry/poetry#9427