Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private property to project properties blocks publishing without -r #2322

Closed
wants to merge 2 commits into from

Conversation

utek
Copy link

@utek utek commented Apr 19, 2020

This PR add ability to set project as a private one. This would turn off default behavior of poetry publish of publishing to official pypi repository.
This can prevent accidental pushes of private packages to public repository.

Requires: python-poetry/poetry-core#27

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of quick comments.

poetry/publishing/publisher.py Outdated Show resolved Hide resolved
poetry/publishing/publisher.py Outdated Show resolved Hide resolved
docs/docs/pyproject.md Outdated Show resolved Hide resolved
@utek utek requested a review from abn April 19, 2020 13:36
@utek utek closed this Sep 25, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants