Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

direct URL dependencies are never outdated #6396

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Sep 4, 2022

I had intended just to tidy up a couple of places that missed the opportunity to use package.is_direct_origin(), but in doing so I found one that ought to do that - and that missed "url" source type.

If a requirement specifies a direct URL, then that doesn't become outdated just because a newer version of the same package happens to be available in a repository.

(Or anyway if it does, then the same ought to apply to other direct-origin types, the url source type is not special)

@radoering radoering merged commit 72db06e into python-poetry:master Sep 9, 2022
@dimbleby dimbleby deleted the direct-origin-tidying branch September 9, 2022 16:42
@neersighted neersighted added kind/enhancement Not a bug or feature, but improves usability or performance impact/changelog Requires a changelog entry labels Sep 17, 2022
@neersighted neersighted added this to the 1.3 milestone Sep 17, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact/changelog Requires a changelog entry kind/enhancement Not a bug or feature, but improves usability or performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants