Misc fixes #8253
Merged
Misc fixes #8253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radoering
approved these changes
Aug 4, 2023
Comment on lines
-477
to
-480
| if len(unsatisfied) == 1: | ||
| dependency = unsatisfied[0] | ||
| else: | ||
| dependency = min(*unsatisfied, key=_get_min) |
There was a problem hiding this comment.
This could be a performance optimization, but I suppose it does not matter. If it was an optimization it should have a comment telling us so anyway.
poetry is already using requests, and the docstring for requests.utils indicates that "this module provides utility functions ... that are also useful for external consumption". ie there's no reason copy the code, just use it.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small collection of updates and clean-ups: not fixing anything in particular but keeping current, preparing for deprecations, tightening type-checking, etc.
Probably best reviewed one commit at a time.