Add plumbing for legacy repository search and refactor repository fixtures #9132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abn
force-pushed
the
issue/2446
branch
2 times, most recently
from
65ffc40
to
1a6a879
Compare
|
Issue was due to response for |
abn
force-pushed
the
issue/2446
branch
2 times, most recently
from
164b093
to
8853969
Compare
abn
changed the title
abn
force-pushed
the
issue/2446
branch
3 times, most recently
from
8d778ba
to
f8a3eb7
Compare
Secrus
previously requested changes
Mar 14, 2024
abn
force-pushed
the
issue/2446
branch
3 times, most recently
from
dacecc4
to
3265506
Compare
dimbleby
reviewed
Mar 17, 2024
This change removes a stubbing change added in 46ae4f5. This change was incorrect, as the base class already sets package list to an empty list. The test case was also incorrect as it forced addition to internal package list.
This change introduces httpretty based mocking for tests using mocked legacy or pypi repositories. This also fixes various issues with tests incorrectly relying on remote versions for metadata and distributions instead of expected mocked versions. Additionally, we also auto enables PyPI repository mocking to ensure no external requests are made without explicit handling. Further, a new `generate.py` script has now been added to help regenerate existing repository json and distribution fixtures; or add/remove release versions to the fixtures.
Secrus
approved these changes
Mar 17, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for simple search in legacy repositories.
Relates-to: #2446
Remove unwanted stubbing of
LegacyRepository.packagesThis change removes a stubbing change added in 46ae4f5. This change was incorrect, as the base class already sets package list to an empty list.
The test case was also incorrect as it forced addition to internal package list.
This change introduces httpretty based mocking for tests using mocked legacy or pypi repositories. This also fixes various issues with tests incorrectly relying on remote versions for metadata and distributions instead of expected mocked versions. Additionally, we also auto enables PyPI repository mocking to ensure no external requests are made without explicit handling. Further, a new
generate.pyscript has now been added to help regenerate existing repository json and distribution fixtures; or add/remove release versions to the fixtures.These changes also lead to the fixing of an incorrect handling of sdist inspection.