Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self install: in this context the project is not a package so we should set package-mode #9302

Merged

Conversation

radoering
Copy link
Member

@radoering radoering commented Apr 12, 2024

Pull Request Check List

Derived from: #7990 (comment)

  • Added tests for changed code.
  • Updated documentation for changed code.

@radoering radoering added impact/backport Requires backport to stable branch backport/1.8 Backport a PR to 1.8 through an automated PR labels Apr 12, 2024
@radoering radoering force-pushed the fix-poetry-self-install-non-package branch from 122e219 to d8f396f Compare April 12, 2024 13:51
@radoering radoering requested a review from a team April 22, 2024 16:06
@radoering radoering force-pushed the fix-poetry-self-install-non-package branch from d8f396f to fbc3dfc Compare April 23, 2024 18:05
@radoering radoering force-pushed the fix-poetry-self-install-non-package branch from fbc3dfc to 87d8641 Compare April 26, 2024 13:39
@radoering radoering enabled auto-merge (squash) April 26, 2024 13:48
@radoering radoering merged commit ef75e7c into python-poetry:main Apr 26, 2024
60 checks passed
@neersighted neersighted added backport/1.8 Backport a PR to 1.8 through an automated PR and removed backport/1.8 Backport a PR to 1.8 through an automated PR labels Apr 26, 2024
@radoering radoering added backport/1.8 Backport a PR to 1.8 through an automated PR and removed backport/1.8 Backport a PR to 1.8 through an automated PR labels Apr 29, 2024
@poetry-bot
Copy link

poetry-bot bot commented Apr 29, 2024

The backport to 1.8 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8 1.8
# Navigate to the new working tree
cd .worktrees/backport-1.8
# Create a new branch
git switch --create backport-9302-to-1.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ef75e7c85508cca498be7c630d8373a5c0b26586
# Push it to GitHub
git push --set-upstream origin backport-9302-to-1.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8

Then, create a pull request where the base branch is 1.8 and the compare/head branch is backport-9302-to-1.8.

@radoering radoering added backport/1.8 Backport a PR to 1.8 through an automated PR and removed backport/1.8 Backport a PR to 1.8 through an automated PR labels Apr 29, 2024
@poetry-bot
Copy link

poetry-bot bot commented Apr 29, 2024

The backport to 1.8 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8 1.8
# Navigate to the new working tree
cd .worktrees/backport-1.8
# Create a new branch
git switch --create backport-9302-to-1.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ef75e7c85508cca498be7c630d8373a5c0b26586
# Push it to GitHub
git push --set-upstream origin backport-9302-to-1.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8

Then, create a pull request where the base branch is 1.8 and the compare/head branch is backport-9302-to-1.8.

@radoering radoering added backport/1.8 Backport a PR to 1.8 through an automated PR and removed backport/1.8 Backport a PR to 1.8 through an automated PR labels Apr 30, 2024
poetry-bot bot pushed a commit that referenced this pull request Apr 30, 2024
…ld set package-mode to false (#9302)

(cherry picked from commit ef75e7c)
radoering added a commit that referenced this pull request Apr 30, 2024
…ld set package-mode to false (#9302)

(cherry picked from commit ef75e7c)
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.8 Backport a PR to 1.8 through an automated PR impact/backport Requires backport to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants