This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Improve CI reliability #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
=======================================
Coverage 98.82% 98.82%
=======================================
Files 22 22
Lines 3233 3233
=======================================
Hits 3195 3195
Misses 38 38 |
The Codecov code handles retries correctly, but the GitHub Actions sometimes fails to fetch it. Trio has found a way to fetch the code that works reliably, so let's use it.
pquentin
force-pushed
the
curl-harder-codecov
branch
from
2b516f2
to
0062299
Compare
.github/workflows/ci.yml
Outdated
| name: codecov-umbrella | ||
| yml: ./codecov.yml | ||
| fail_ci_if_error: true | ||
| run: ./_travis/upload_coverage.sh |
There was a problem hiding this comment.
Just a suggestion, we should put our CI script like upload_coverage.sh in a folder maybe named ci.
There was a problem hiding this comment.
@RatanShreshtha I renamed _travis/ to ci/, please take another look
sethmlarson
reviewed
May 11, 2020
| @@ -1287,6 +1288,7 @@ def socket_handler(listener): | |||
| finally: | |||
| timed_out.set() | |||
|
|
|||
| @skipPyPy3 | |||
sethmlarson
approved these changes
May 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see two failures frequently: PyPy3 hangs, and coverage upload failures. I had two PRs, but each PR failed because it did not have the fix from the other one!
The Codecov code handles retries correctly, but the GitHub Actions sometimes fails to fetch it: codecov/codecov-action#71
Trio has found a way to fetch the code that works reliably, so let's use it. As a bonus, the job names in Codecov now make sense.