Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] First pass of mypy-cleanliness #1254

Closed
wants to merge 1 commit into from

Conversation

oremanj
Copy link
Member

@oremanj oremanj commented Oct 17, 2019

The goal of this PR is to make mypy -p trio work.

WIP because there are still some errors:

  • "cmp is deprecated, use eq and order" thrown by attrs plugin: will be resolved by upgrading attrs
  • Path needs a stubs file
  • 3-4 others that I ran out of time to fix on the flight

And we should add mypy to CI once it's working so it stays working.

@pquentin
Copy link
Member

"cmp is deprecated, use eq and order" thrown by attrs plugin: will be resolved by upgrading attrs

We need a release of python-trio/outcome#25 before we can fix attrs in trio proper

@pquentin
Copy link
Member

Okay, the attrs fix has landed in master. :)

@oremanj
Copy link
Member Author

oremanj commented Jul 1, 2020

Superseded by recent work

@oremanj oremanj closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants