Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for calling trio.Process() directly #1496

Merged
merged 1 commit into from
May 6, 2020

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented May 6, 2020

Closes gh-1109

njsmith added a commit to njsmith/trio that referenced this pull request May 6, 2020
This is a pretty trivial change, but I noticed it while working on
python-triogh-1496 so I figured I'd just fix it.
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #1496 into master will increase coverage by 6.91%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
+ Coverage   92.76%   99.67%   +6.91%     
==========================================
  Files         107      107              
  Lines       13220    13212       -8     
  Branches      995      995              
==========================================
+ Hits        12263    13169     +906     
+ Misses        904       28     -876     
+ Partials       53       15      -38     
Impacted Files Coverage Δ
trio/tests/test_subprocess.py 100.00% <ø> (+4.43%) ⬆️
trio/_subprocess.py 100.00% <100.00%> (+2.25%) ⬆️
trio/tests/test_testing.py 100.00% <0.00%> (+0.18%) ⬆️
trio/tests/test_highlevel_socket.py 100.00% <0.00%> (+0.63%) ⬆️
trio/_core/_run.py 99.74% <0.00%> (+0.90%) ⬆️
trio/_core/tests/test_io.py 100.00% <0.00%> (+1.75%) ⬆️
trio/tests/test_unix_pipes.py 100.00% <0.00%> (+2.06%) ⬆️
trio/_highlevel_open_tcp_listeners.py 100.00% <0.00%> (+2.12%) ⬆️
trio/_unix_pipes.py 100.00% <0.00%> (+2.27%) ⬆️
... and 20 more

@oremanj oremanj merged commit 0ca6b1d into python-trio:master May 6, 2020
@oremanj
Copy link
Member

oremanj commented May 6, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put process-creation into a thread
2 participants