Add high-level Listener interface #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No semantic changes
{memory,lockstep}_stream_pair are more useful
Now that we have a clear delineation between the high-level and low-level interfaces, this should go into the high-level interface.
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
==========================================
+ Coverage 99.13% 99.16% +0.02%
==========================================
Files 76 79 +3
Lines 9269 9658 +389
Branches 655 686 +31
==========================================
+ Hits 9189 9577 +388
- Misses 62 63 +1
Partials 18 18
Continue to review full report at Codecov.
|
No more port=None or port="" or port=bytestring -- they're not useful and they can have weird/non-portable behavior. Also don't accept service names (port="http") -- it would work, but they aren't necessarily portable, I can't find evidence that anyone uses them, and they violate TOOWTDI. I'd rather not support things I wouldn't recommend using. Also don't allow host=None in open_tcp_stream -- this is redundant with the loopback address. I guess this *could* be useful in some weird case, but we can always add it back later if someone wants it.
|
Actually, it looks like we need to resolve #284 before adding server helpers, so I'm going to defer that part to another PR and get this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
open_ssl_over_tcp_listenersstart_listening_server(or maybespawn_listening_server?)start_{tcp,ssl_over_tcp}_serverswitch to preferring port=None instead of port=0 for "pick anever mind, see bpo-31198random port" (apparently python's getaddrinfo treats them the same)
maybe makeOTOH twisted and tornado don't and it makes How to handle automatic port selection in open_tcp_listeners when we have multiple sockets? #283 more complicated, so never mind. We can always add it later; it's a backwards compatible change.open_tcp_listenersaccept a list of host names? notsure if this is really useful. But asyncio supports it.