Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mypy and disable jedi on PyPy #3075

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Aug 29, 2024

Refs #2885

I remember jedi being somewhat flaky on PyPy so this should fix that.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.61%. Comparing base (4ae737a) to head (36ab775).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3075      +/-   ##
==========================================
- Coverage   99.61%   99.61%   -0.01%     
==========================================
  Files         121      121              
  Lines       17880    17878       -2     
  Branches     3214     3213       -1     
==========================================
- Hits        17812    17810       -2     
  Misses         48       48              
  Partials       20       20              
Files with missing lines Coverage Δ
src/trio/_tests/test_exports.py 99.61% <100.00%> (-0.01%) ⬇️

@A5rocks A5rocks mentioned this pull request Aug 29, 2024
17 tasks
Copy link
Member

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell

@A5rocks A5rocks merged commit 51c8f9c into python-trio:main Aug 30, 2024
35 of 37 checks passed
@A5rocks A5rocks deleted the jedi-and-mypy-on-pypy branch August 30, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants