Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yapf version to 0.20.1 #406

Merged
merged 3 commits into from
Jan 19, 2018
Merged

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Jan 19, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jan 19, 2018

Codecov Report

Merging #406 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #406   +/-   ##
======================================
  Coverage    99.2%   99.2%           
======================================
  Files          89      89           
  Lines       10332   10332           
  Branches      719     719           
======================================
  Hits        10250   10250           
  Misses         63      63           
  Partials       19      19
Impacted Files Coverage Δ
trio/_socket.py 100% <ø> (ø) ⬆️
trio/_util.py 94.78% <ø> (ø) ⬆️
trio/testing/_check_streams.py 98.53% <ø> (ø) ⬆️
trio/_sync.py 100% <ø> (ø) ⬆️
trio/_core/tests/test_run.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 645e5bb...5b2ffe2. Read the comment docs.

@pquentin
Copy link
Member

Okay so this was not based on master, so I merged master into this branch and ran yapf again because there were other changes. I'd be happy if someone could double check that I did not make a mistake here.

(I first made a mistake so I had to force push, and I also deleted a codecov comment because for some reason codecov commented twice before my force push.)

(Oh, and the way we use yapf is not really that satisfactory, because we're going to have friction like in #401 for every yapf upgrade. But I don't know what else could be done.)

@njsmith
Copy link
Member Author

njsmith commented Jan 19, 2018

Codecov likes to randomly double comment. I don't know why. But it does it a lot.

Oh, and the way we use yapf is not really that satisfactory, because we're going to have friction like in #401 for every yapf upgrade

Maybe... going forward yapf will keep working, and we'll be able to track the latest release without any problems, and everything will be sunshine and rainbows?

...yeah, idk. At least for now we are up to date with the latest release, so we've kicked the problem down the road a bit. Maybe there's some clever way to use pyup.io or requires.io?

@njsmith njsmith merged commit 3170205 into python-trio:master Jan 19, 2018
@njsmith njsmith deleted the yapf-0.20.1 branch January 19, 2018 12:11
@pquentin
Copy link
Member

...yeah, idk. At least for now we are up to date with the latest release, so we've kicked the problem down the road a bit. Maybe there's some clever way to use pyup.io or requires.io?

I agree this can wait. Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants