Generalize namespace static analysis tests #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches to a single parametrized test that covers all of Trio's public namespaces, and if it fails, then it prints a nice readable list of the missing symbols. Also adds the symbols that were missing from trio.socket's static import list on my laptop, and adds some comments to trio.socket while I'm at it.
Codecov Report
@@ Coverage Diff @@
## master #756 +/- ##
==========================================
- Coverage 99.34% 99.32% -0.02%
==========================================
Files 96 96
Lines 11586 11597 +11
Branches 827 831 +4
==========================================
+ Hits 11510 11519 +9
- Misses 56 57 +1
- Partials 20 21 +1
Continue to review full report at Codecov.
|
pquentin
approved these changes
Oct 29, 2018
| for (_name, _value) in _stdlib_socket.__dict__.items() | ||
| if _name.isupper() and not _name.startswith('_') | ||
| _name: getattr(_stdlib_socket, _name) | ||
| for _name in _stdlib_socket.__all__ if _name.isupper() |
There was a problem hiding this comment.
Any reason to change this again?
pquentin
reviewed
Oct 29, 2018
| if not value.__name__.startswith(module.__name__): | ||
| continue | ||
| if value is module: | ||
| continue |
There was a problem hiding this comment.
(This line does not seem to be covered by the tests.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to a single parametrized test that covers all of Trio's
public namespaces, and if it fails, then it prints a nice readable
list of the missing symbols.
Also adds the symbols that were missing from trio.socket's static
import list on my laptop, and adds some comments to trio.socket while
I'm at it.
CC: @jmfrank63 @Zac-HD