Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark failing IPython multierror tests as xfail on 3.8 #905

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

oremanj
Copy link
Member

@oremanj oremanj commented Feb 5, 2019

Until ipython/ipython#11590 is fixed.

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #905 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
+ Coverage   99.53%   99.53%   +<.01%     
==========================================
  Files         102      102              
  Lines       12411    12414       +3     
  Branches      916      916              
==========================================
+ Hits        12353    12356       +3     
  Misses         36       36              
  Partials       22       22
Impacted Files Coverage Δ
trio/_core/tests/test_multierror.py 100% <100%> (ø) ⬆️

@njsmith
Copy link
Member

njsmith commented Feb 5, 2019

Awesome, thanks!

@njsmith njsmith merged commit b2143c9 into python-trio:master Feb 5, 2019
@oremanj oremanj deleted the disable-38-differently branch February 5, 2019 18:09
@Carreau
Copy link
Contributor

Carreau commented Feb 5, 2019

See ipython/ipython#11593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants