Add the ability for cancel scopes to specify a grace period #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oremanj
force-pushed
the
graceperiod3
branch
from
7c0b770
to
9e4b439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147.
I know there's still some debate in #147 about what form this should take, but I wanted to provide an example of what "Type 2" graceful cancellation might look like. I'm open to suggestions on the names.
(You can implement "Type 1" easily in terms of "Type 2"; just write
with trio.shield_during_cleanup():around each request. It probably wants a different name in that case, though.)