Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOAD_SUPER_ATTR doesn't match monitoring behavior of the opcodes it replaces #103865

Closed
carljm opened this issue Apr 26, 2023 · 0 comments · Fixed by #103866
Closed

LOAD_SUPER_ATTR doesn't match monitoring behavior of the opcodes it replaces #103865

carljm opened this issue Apr 26, 2023 · 0 comments · Fixed by #103866
Labels
type-bug An unexpected behavior, bug, or error

Comments

@carljm
Copy link
Member

carljm commented Apr 26, 2023 •
edited by bedevere-bot
Loading

The LOAD_SUPER_ATTR super-instruction optimization doesn't correctly match the PEP 669 monitoring events that would be fired by the call to super() followed by attribute load that it replaces. This should be fixed.

Linked PRs
@carljm carljm added the type-bug An unexpected behavior, bug, or error label Apr 26, 2023
carljm added a commit to carljm/cpython that referenced this issue Apr 26, 2023
@carljm
pythongh-103865: add monitoring support to LOAD_SUPER_ATTR
862c3dc
@bedevere-bot bedevere-bot mentioned this issue Apr 26, 2023
Merged
@carljm carljm linked a pull request May 11, 2023 that will close this issue
gh-103865: add monitoring support to LOAD_SUPER_ATTR #103866
Merged
carljm added a commit that referenced this issue May 16, 2023
@carljm
gh-103865: add monitoring support to LOAD_SUPER_ATTR (#103866)
f40890b
carljm added a commit to carljm/cpython that referenced this issue May 17, 2023
@carljm
Merge branch 'main' into 709funconly
b1bb3a7 
* main: (26 commits)
  pythonGH-101520: Move tracemalloc functionality into core, leaving interface in Modules. (python#104508)
  typing: Add more tests for TypeVar (python#104571)
  pythongh-104572: Improve error messages for invalid constructs in PEP 695 contexts (python#104573)
  typing: Use PEP 695 syntax in typing.py (python#104553)
  pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (python#102508)
  pythongh-104469: Update README.txt for _testcapi (pythongh-104529)
  pythonGH-103092: isolate `_elementtree` (python#104561)
  pythongh-104050: Add typing to Argument Clinic converters (python#104547)
  pythonGH-103906: Remove immortal refcounting in the interpreter (pythonGH-103909)
  pythongh-87474: Fix file descriptor leaks in subprocess.Popen (python#96351)
  pythonGH-103092: isolate `pyexpat`  (python#104506)
  pythongh-75367: Fix data descriptor detection in inspect.getattr_static (python#104517)
  pythongh-104050: Add more annotations to `Tools/clinic.py` (python#104544)
  pythongh-104555: Fix isinstance() and issubclass() for runtime-checkable protocols that use PEP 695 (python#104556)
  pythongh-103865: add monitoring support to LOAD_SUPER_ATTR (python#103866)
  CODEOWNERS: Assign new PEP 695 files to myself (python#104551)
  pythonGH-104510: Fix refleaks in `_io` base types (python#104516)
  pythongh-104539: Fix indentation error in logging.config.rst (python#104545)
  pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)
  pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-103865: add monitoring support to LOAD_SUPER_ATTR carljm/cpython
1 participant
@carljm