Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run mypy on Tools/peg_generator #108455

Closed
sobolevn opened this issue Aug 24, 2023 · 0 comments · Fixed by #109160
Closed

Run mypy on Tools/peg_generator #108455

sobolevn opened this issue Aug 24, 2023 · 0 comments · Fixed by #109160
Assignees
@sobolevn
Labels
type-feature A feature request or enhancement

Comments

@sobolevn
Copy link
Member

sobolevn commented Aug 24, 2023 •
edited by bedevere-bot
Loading

Feature or enhancement

Now that we have mypy infrastructure ready https://github.com/python/cpython/blob/main/.github/workflows/mypy.yml we can add more things to the test.

https://github.com/python/cpython/tree/main/Tools/peg_generator has mypy.ini and annotations. So, let's check it as well.

How I plan to do it (separate PRs):

  1. Start small with the CI job itself and initial fixes
  2. Add types-setuptools dependency and fix more problems
  3. Update config to be stricter and refactor

Linked PRs
@sobolevn sobolevn added the type-feature A feature request or enhancement label Aug 24, 2023
@sobolevn sobolevn self-assigned this Aug 24, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Aug 24, 2023
@sobolevn
pythongh-108455: Run mypy on Tools/peg_generator
a33e5a9
@bedevere-bot bedevere-bot mentioned this issue Aug 24, 2023
Merged
sobolevn added a commit to sobolevn/cpython that referenced this issue Aug 24, 2023
@sobolevn
pythongh-108455: Run mypy on Tools/peg_generator
c08b596
pablogsal pushed a commit that referenced this issue Aug 28, 2023
@sobolevn @hugovk
gh-108455: Run mypy on Tools/peg_generator (#108456)
cf7ba83 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Aug 29, 2023
Merged
AlexWaygood added a commit to AlexWaygood/cpython that referenced this issue Aug 29, 2023
@AlexWaygood
pythongh-108455: Simplify the peg_generator mypy config
d52c15a
AlexWaygood added a commit that referenced this issue Aug 29, 2023
@AlexWaygood
gh-108455: Simplify the peg_generator mypy config (#108620)
c879b9f 
make it easier to see exactly which options from mypy's `--strict` mode can't currently be enabled
@bedevere-bot bedevere-bot mentioned this issue Aug 29, 2023
Merged
sobolevn added a commit to sobolevn/cpython that referenced this issue Aug 29, 2023
@sobolevn
pythongh-108455: Use strict_optional=True for grammar_parser
2d5e594
@bedevere-bot bedevere-bot mentioned this issue Aug 29, 2023
Merged
AlexWaygood added a commit that referenced this issue Aug 29, 2023
@AlexWaygood
gh-108455: peg_generator: make the mypy config slightly stricter (#10…
0d140b8 
…8627)

* Enable `--no-implicit-reexport`

* Enable the `truthy-bool` error code

* Enable the `ignore-without-code` error code

* Explicitly note that `--warn-unreachable` cannot yet be enabled
AlexWaygood pushed a commit that referenced this issue Aug 29, 2023
@sobolevn
gh-108455: peg generator: Use strict_optional=True for `grammar_par…
f8be2e2 
…ser` (#108629)
@bedevere-bot bedevere-bot mentioned this issue Aug 29, 2023
Merged
AlexWaygood added a commit that referenced this issue Aug 29, 2023
@AlexWaygood
gh-108455: peg_generator: install two stubs packages before running m…
77e8f23 
…ypy (#108637)
@AlexWaygood AlexWaygood mentioned this issue Aug 30, 2023
Merged
carljm added a commit to carljm/cpython that referenced this issue Aug 30, 2023
@carljm
Merge branch 'main' into icompexc
37377e6 
* main:
  pythongh-108520: Fix bad fork detection in nested multiprocessing use case (python#108568)
  pythongh-108590: Revert pythongh-108657 (commit 400a1ce) (python#108686)
  pythongh-108494: Argument Clinic: Document how to generate code that uses the limited C API (python#108584)
  Document Python build requirements (python#108646)
  pythongh-101100: Fix Sphinx warnings in the Logging Cookbook (python#108678)
  Fix typo in multiprocessing docs (python#108666)
  pythongh-108669: unittest: Fix documentation for TestResult.collectedDurations (python#108670)
  pythongh-108590: Fix sqlite3.iterdump for invalid Unicode in TEXT columns (python#108657)
  Revert "pythongh-103224: Use the realpath of the Python executable in `test_venv` (pythonGH-103243)" (pythonGH-108667)
  pythongh-106320: Remove private _Py_ForgetReference() (python#108664)
  Mention Ellipsis pickling in the docs (python#103660)
  Revert "Use non alternate name for Kyiv (pythonGH-108533)" (pythonGH-108649)
  pythongh-108278: Deprecate passing the first param of sqlite3.Connection callback APIs by keyword (python#108632)
  pythongh-108455: peg_generator: install two stubs packages before running mypy (python#108637)
  pythongh-107801: Improve the accuracy of io.IOBase.seek docs (python#108268)
@bedevere-bot bedevere-bot mentioned this issue Aug 30, 2023
Merged
AlexWaygood added a commit that referenced this issue Aug 31, 2023
@AlexWaygood
gh-108455: peg_generator: use types-setuptools==68.1.0.1 in CI (#10…
b89b838 
…8697)
@sobolevn sobolevn mentioned this issue Sep 8, 2023
Closed
@AlexWaygood AlexWaygood mentioned this issue Sep 8, 2023
Merged
pablogsal pushed a commit that referenced this issue Sep 8, 2023
@AlexWaygood
gh-108455: peg_generator: enable mypy's --warn-unreachable setting …
697c9dc 
…and `redundant-expr` error code (#109160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
1 participant
@sobolevn