Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Unicode C API #99593

Closed
serhiy-storchaka opened this issue Nov 19, 2022 · 1 comment
Closed

Add tests for Unicode C API #99593

serhiy-storchaka opened this issue Nov 19, 2022 · 1 comment
Labels
3.12 bugs and security fixes tests Tests in the Lib/test dir topic-C-API type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Nov 19, 2022 •
edited by bedevere-bot
Loading

Several years ago I started to write tests for Unicode C API. It required a lot of effort, because this category is big, so after doing 2/3 of the work I put it off for later. Certain circumstances prevented me from completing it. But now I found time to return to it.

In the meantime, other people have done some of this work (moving parts of the _testcapi.c to a separate files, adding coverage for more C API functions), and some of the legacy C API has been removed. Therefore, it took more than a week to arrange the code, fix conflicts, remove outdated tests and write remaining tests. But some errors may still remain, be careful.

Linked PRs
@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement tests Tests in the Lib/test dir needs backport to 3.10 only security fixes topic-C-API needs backport to 3.11 only security fixes labels Nov 19, 2022
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 19, 2022
@serhiy-storchaka
pythongh-99593: Add tests for Unicode C API
b6bfd11
@bedevere-bot bedevere-bot mentioned this issue Nov 19, 2022
Closed
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 19, 2022
@serhiy-storchaka
pythongh-99593: Add tests for Unicode C API
8bf0e29
@serhiy-storchaka serhiy-storchaka mentioned this issue Nov 20, 2022
Closed
@serhiy-storchaka serhiy-storchaka added 3.11 only security fixes 3.10 only security fixes 3.12 bugs and security fixes and removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 20, 2022
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 21, 2022
@serhiy-storchaka
pythongh-99593: Add tests for Unicode C API (part 1)
7f5362f 
Add tests for functions corresponding to the str class methods.
@bedevere-bot bedevere-bot mentioned this issue Nov 21, 2022
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 21, 2022
@serhiy-storchaka
pythongh-99593: Add tests for Unicode C API (part 2)
31c2827 
Add tests for lower-level functions.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 23, 2022
@serhiy-storchaka
pythongh-99593: Add tests for Unicode C API (part 3)
160276c 
Add tests for codecs related functions.
serhiy-storchaka added a commit that referenced this issue Nov 29, 2022
@serhiy-storchaka
gh-99593: Add tests for Unicode C API (part 1) (GH-99651)
deaa8de 
Add tests for functions corresponding to the str class methods.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 29, 2022
@serhiy-storchaka
pythongh-99593: Add tests for Unicode C API (part 2)
f8754d7 
Add tests for lower-level functions.
@bedevere-bot bedevere-bot mentioned this issue Nov 29, 2022
Merged
vstinner pushed a commit that referenced this issue May 4, 2023
@serhiy-storchaka @arhadthedev
gh-99593: Add tests for Unicode C API (part 2) (#99868)
2ba931f 
Add tests for lower-level functions.

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
carljm added a commit to carljm/cpython that referenced this issue May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2
8a78a36 
* main: (61 commits)
  pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
  pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
  pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
  pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
  pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
  pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
  pythongh-104190: fix ubsan crash (python#104191)
  pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
  pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
  pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
  pythongh-68968: Correcting message display issue with assertEqual (python#103937)
  pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
  pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
  pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
  pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
  pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
  pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
  pythongh-102500: Document PEP 688 (python#102571)
  pythongh-102500: Implement PEP 688 (python#102521)
  pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
  ...
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue May 21, 2023
@serhiy-storchaka
pythongh-99593: Add tests for Unicode C API (part 3)
f3c2360 
Add tests for codecs.
@bedevere-bot bedevere-bot mentioned this issue May 21, 2023
Merged
serhiy-storchaka added a commit that referenced this issue Jul 10, 2023
@serhiy-storchaka
gh-99593: Add tests for Unicode C API (part 3) (GH-104728)
51ea664 
Add tests for codecs.
@serhiy-storchaka serhiy-storchaka removed 3.11 only security fixes 3.10 only security fixes labels Jul 10, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jul 10, 2023
@serhiy-storchaka
[3.12] pythongh-99593: Add tests for Unicode C API (part 3) (pythonGH…
f40e37a 
…-104728)

Add tests for codecs..
(cherry picked from commit 51ea664)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Jul 10, 2023
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jul 10, 2023
@serhiy-storchaka
[3.12] pythongh-99593: Add tests for Unicode C API (part 3) (pythonGH…
d282c4e 
…-104728)

Add tests for codecs.
(cherry picked from commit 51ea664)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this issue Jul 10, 2023
@serhiy-storchaka
[3.12] gh-99593: Add tests for Unicode C API (part 3) (GH-104728) (GH…
2da967e 
…-106595)

Add tests for codecs.
(cherry picked from commit 51ea664)
@vstinner
Copy link
Member

Can the issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes tests Tests in the Lib/test dir topic-C-API type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vstinner @serhiy-storchaka