Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101659: Isolate "obmalloc" State to Each Interpreter #101660

Merged
merged 58 commits into from
Apr 24, 2023
Merged

gh-101659: Isolate "obmalloc" State to Each Interpreter #101660

merged 58 commits into from
Apr 24, 2023

Commits on Feb 7, 2023

  1. Pass PyInterpreterState to pymalloc_*().

    @ericsnowcurrently
    ericsnowcurrently committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    07a09d4 View commit details
    Browse the repository at this point in the history

  2. Move the object arenas to the interpreter state.

    @ericsnowcurrently
    ericsnowcurrently committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    ca75048 View commit details
    Browse the repository at this point in the history

  3. Drop an errant #define.

    @ericsnowcurrently
    ericsnowcurrently committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    4ee199b View commit details
    Browse the repository at this point in the history

  4. Leave dump_debug_stats in the global state.

    @ericsnowcurrently
    ericsnowcurrently committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    2768fa4 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Dynamically initialize obmalloc for subinterpreters.

    @ericsnowcurrently
    ericsnowcurrently committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    bf9425f View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Merge branch 'main' into per-interpreter-alloc

    @ericsnowcurrently
    ericsnowcurrently committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    d5da34b View commit details
    Browse the repository at this point in the history

  2. Pass around struct _obmalloc_state* instead of PyInterpeterState*.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    6c3111c View commit details
    Browse the repository at this point in the history

  3. Add _PyInterpreterConfig.use_main_obmalloc.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    4dc087d View commit details
    Browse the repository at this point in the history

  4. Add a comment about why per-interpreter obmalloc requires multi-phase… 

    … init extensions.
    @ericsnowcurrently
    ericsnowcurrently committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    1ae33a0 View commit details
    Browse the repository at this point in the history

  5. Add a TODO comment.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    5b54d63 View commit details
    Browse the repository at this point in the history

  6. Optionally use the main interpreter's obmalloc state.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    9f4f8f3 View commit details
    Browse the repository at this point in the history

  7. Pass use_main_obmalloc to run_in_subinterp() in test_import.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    aa10204 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. _Py_GetAllocatedBlocks() -> _Py_GetGlobalAllocatedBlocks().

    @ericsnowcurrently
    ericsnowcurrently committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    69d9a2d View commit details
    Browse the repository at this point in the history

  2. Errors from _Py_NewInterpreterFromConfig() are no longer fatal.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    25378f8 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Chain the exceptions.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    1c5b109 View commit details
    Browse the repository at this point in the history

  2. Swap out the failed tstate.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    f36426b View commit details
    Browse the repository at this point in the history

  3. Remaining static builtin types must be fixed.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    54b9f09 View commit details
    Browse the repository at this point in the history

  4. Add PyInterpreterState.sysdict_copy.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    2358a42 View commit details
    Browse the repository at this point in the history

  5. Set m_copy to None for sys and builtins.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    b6502e1 View commit details
    Browse the repository at this point in the history

  6. Add _PyIO_InitTypes().

    @ericsnowcurrently
    ericsnowcurrently committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    678e67b View commit details
    Browse the repository at this point in the history

  7. Fix test_capi.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    69a5829 View commit details
    Browse the repository at this point in the history

  8. Avoid allocation for shared exceptions.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    3feb408 View commit details
    Browse the repository at this point in the history

  9. Fix the ChannelID tp_name.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    05806fc View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Merge branch 'main' into per-interpreter-alloc

    @ericsnowcurrently
    ericsnowcurrently committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    b1cd7bb View commit details
    Browse the repository at this point in the history

  2. Do not include the total from interpreters sharing with main.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    4feb2b7 View commit details
    Browse the repository at this point in the history

  3. Add _PyRuntime.obmalloc.interpreter_leaks.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    136ad2f View commit details
    Browse the repository at this point in the history

  4. Track leaked blocks across init/fini cycles.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    e19bb37 View commit details
    Browse the repository at this point in the history

  5. Clean up assumptions around runtime fini.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    6c51997 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into per-interpreter-alloc

    @ericsnowcurrently
    ericsnowcurrently committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    f0fcaf6 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Add stubs for when WITH_PYMALLOC isn't defined.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    0ff65ff View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Decref the key in the right interpreter in _extensions_cache_set().

    @ericsnowcurrently
    ericsnowcurrently committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    7db8d4a View commit details
    Browse the repository at this point in the history

  2. Don't test against sys (for now).

    @ericsnowcurrently
    ericsnowcurrently committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    38bee89 View commit details
    Browse the repository at this point in the history

  3. Clean up SubinterpImportTests.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    375a8f2 View commit details
    Browse the repository at this point in the history

  4. Ensure we are testing against the right type of extension.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    b0a9e11 View commit details
    Browse the repository at this point in the history

  5. Add a test that uses an isolated interpreter.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    5e5d5d5 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Fix is_core_module().

    @ericsnowcurrently
    ericsnowcurrently committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    25809ce View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into per-interpreter-alloc

    @ericsnowcurrently
    ericsnowcurrently committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    616d3dd View commit details
    Browse the repository at this point in the history

  3. Ignore last_final_leaks.

    @ericsnowcurrently
    ericsnowcurrently committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    43a836b View commit details
    Browse the repository at this point in the history

  4. Fix a typo.

    @ericsnowcurrently
    ericsnowcurrently committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    1841b55 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into per-interpreter-alloc

    @ericsnowcurrently
    ericsnowcurrently committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    299527e View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Add a note about global state owned by the module.

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    0091e48 View commit details
    Browse the repository at this point in the history

  2. Factor out GLOBAL_MALLOC() and GLOBAL_FREE().

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    9f74f7b View commit details
    Browse the repository at this point in the history

  3. Switch to the raw allocator.

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    10c3589 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'channels-raw-allocator' into per-interpreter-alloc

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    ff727ec View commit details
    Browse the repository at this point in the history

  5. Use the raw allocator for _PyCrossInterpreterData_InitWithSize().

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    593430b View commit details
    Browse the repository at this point in the history

  6. atexit_callback -> atexit_py_callback.

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f5ae710 View commit details
    Browse the repository at this point in the history

  7. Add pycore_atexit.h.

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e6d4776 View commit details
    Browse the repository at this point in the history

  8. Add _Py_AtExit().

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c719f02 View commit details
    Browse the repository at this point in the history

  9. Add a TODO comment.

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    47c302d View commit details
    Browse the repository at this point in the history

  10. Move _Py_AtExit() to the public API.

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    aaeaaa6 View commit details
    Browse the repository at this point in the history

  11. Test a constraint.

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    b5396e4 View commit details
    Browse the repository at this point in the history

  12. Add an atexit callback for _xxinterpchannels.

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    448b48a View commit details
    Browse the repository at this point in the history

  13. Implement the callback.

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c86f738 View commit details
    Browse the repository at this point in the history

  14. Drop the _PyCrossInterpreterData_Clear() call in _xxinterpchannels.

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    1827feb View commit details
    Browse the repository at this point in the history

  15. Drop the _PyCrossInterpreterData_Clear() call in _xxsubinterpreters.

    @ericsnowcurrently
    ericsnowcurrently committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    82b395c View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Merge branch 'atexit-c-callback' into per-interpreter-alloc

    @ericsnowcurrently
    ericsnowcurrently committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    df77a64 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into per-interpreter-alloc

    @ericsnowcurrently
    ericsnowcurrently committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    22758a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Merge branch 'main' into per-interpreter-alloc

    @ericsnowcurrently
    ericsnowcurrently committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    0fd74a9 View commit details
    Browse the repository at this point in the history