gh-101100: Fix sphinx warnings in typing module
#102260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
gvanrossum,
Fidget-Spinner,
JelleZijlstra and
AlexWaygood
as code owners
AlexWaygood
approved these changes
Feb 25, 2023
AlexWaygood
added
needs backport to 3.10
|
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-102262 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2023
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2023
|
GH-102263 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 25, 2023
(cherry picked from commit a498de4) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington
added a commit
that referenced
this pull request
Feb 25, 2023
(cherry picked from commit a498de4) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a warning during doc build inside
typing.rstwhen running withmake html SPHINXERRORHANDLING=-n:It happened because https://docs.python.org/3/library/ssl.html#ssl.SSLObject does not have
__init__documented (since it does not do anything useful).Now the warning is gone: