Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-103193: Micro-optimise helper functions for inspect.getattr_static #103195

Merged
merged 2 commits into from
Apr 5, 2023
Merged

gh-103193: Micro-optimise helper functions for inspect.getattr_static #103195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
469e165
gh-103193: Micro-optimise helper functions for `inspect.getattr_static`
AlexWaygood Apr 2, 2023
49c0352
Address review
AlexWaygood Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Lib/inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1772,9 +1772,9 @@ def trace(context=1):
# ------------------------------------------------ static version of getattr

_sentinel = object()
_static_getmro = type.__dict__['__mro__'].__get__
_get_dunder_dict_of_class = type.__dict__["__dict__"].__get__

def _static_getmro(klass):
return type.__dict__['__mro__'].__get__(klass)

def _check_instance(obj, attr):
instance_dict = {}
Expand Down Expand Up @@ -1802,10 +1802,9 @@ def _is_type(obj):
return True

def _shadowed_dict(klass):
dict_attr = type.__dict__["__dict__"]
for entry in _static_getmro(klass):
try:
class_dict = dict_attr.__get__(entry)["__dict__"]
class_dict = _get_dunder_dict_of_class(entry)["__dict__"]
except KeyError:
pass
else:
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2023-04-02-17-51-08.gh-issue-103193.xrZbM1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Improve performance of :func:`inspect.getattr_static`. Patch by Alex
Waygood.