Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-103810: Fix broken references in dataclasses #103811

Merged
merged 2 commits into from
Apr 24, 2023
Merged

gh-103810: Fix broken references in dataclasses #103811

merged 2 commits into from
Apr 24, 2023

Conversation

olgarithms
Copy link
Contributor

@olgarithms olgarithms commented Apr 24, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot mentioned this pull request Apr 24, 2023
Closed
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Apr 24, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

hugovk
hugovk reviewed Apr 24, 2023
View reviewed changes
Doc/library/dataclasses.rst Outdated Show resolved Hide resolved
@olgarithms @hugovk
Remove extra .
a81eca8 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@ambv ambv added docs Documentation in the Doc dir needs backport to 3.11 only security fixes labels Apr 24, 2023
@ambv ambv merged commit 0f23eda into python:main Apr 24, 2023
@miss-islington
Copy link
Contributor

Thanks @olgarithms for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @olgarithms and @ambv, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 0f23eda4b996dacd19dbe91bd47a30433bf236d2 3.11

@ambv ambv added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Apr 24, 2023
@miss-islington
Copy link
Contributor

Thanks @olgarithms for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @olgarithms and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0f23eda4b996dacd19dbe91bd47a30433bf236d2 3.11

ambv pushed a commit to ambv/cpython that referenced this pull request Apr 24, 2023
@olgarithms @ambv
[3.11] pythongh-103810: Fix broken references in dataclasses (pythonG…
319ab15 
…H-103811)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
(cherry picked from commit 0f23eda)

Co-authored-by: Olga Matoula <olgamatoula@gmail.com>
@bedevere-bot
Copy link

GH-103813 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 24, 2023
ambv added a commit that referenced this pull request Apr 24, 2023
@ambv @olgarithms
[3.11] gh-103810: Fix broken references in dataclasses (GH-103811) (#…
56d50dd 
…103813)

(cherry picked from commit 0f23eda)

Co-authored-by: Olga Matoula <olgamatoula@gmail.com>
@olgarithms olgarithms deleted the fix-issue-103810 branch April 24, 2023 23:41
@olgarithms olgarithms mentioned this pull request Apr 25, 2023
Merged
@hugovk
Copy link
Member

hugovk commented Apr 25, 2023

@olgarithms Thank you very much and congratulations on merging your first pull request to CPython! 🧁🥂🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees

@ambv ambv

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@olgarithms @bedevere-bot @miss-islington @hugovk @ambv