-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-99944: Make dis display the value of oparg of KW_NAMES #103856
Merged
iritkatriel
merged 5 commits into
python:main
from
jkchandalia:remove_hardcoded_const_check
Apr 26, 2023
Merged
GH-99944: Make dis display the value of oparg of KW_NAMES #103856
iritkatriel
merged 5 commits into
python:main
from
jkchandalia:remove_hardcoded_const_check
Apr 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.11 adds a new opcode KW_NAMES that has an entry in co_consts, however the hardcoded check here causes dis to not grab the constant
FYI @iritkatriel |
iritkatriel
reviewed
Apr 25, 2023
iritkatriel
approved these changes
Apr 25, 2023
iritkatriel
changed the title
GH-99944: Add test to verify dis output contains information for KW_NAMES
GH-99944: Make dis display the value of oparg of KW_NAMES
Apr 25, 2023
iritkatriel
added
type-feature
A feature request or enhancement
stdlib
Python modules in the Lib dir
labels
Apr 25, 2023
FYI @nanjekyejoannah |
itamaro
pushed a commit
to itamaro/cpython
that referenced
this pull request
Apr 26, 2023
…on#103856) Co-authored-by: chilaxan <chilaxan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the dis module display the value of the oparg of KW_NAMES.
Co-authored-by: chilaxan chilaxan@gmail.com
Fixes #99944