Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-103906: Avoid refcount changes for True, False, None #103907

Closed
wants to merge 1 commit into from

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Apr 26, 2023

@brandtbucher
Copy link
Member

I was literally about to open this exact same PR! 🙂 I'll just diff it with my branch and see what's different, haha.

Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, my branch has everything in this branch, except it also removes refcounts from UNARY_NOT, POP_JUMP_IF_FALSE, POP_JUMP_IF_TRUE, POP_JUMP_IF_NONE, and POP_JUMP_IF_NOT_NONE, and PyBool_FromLong.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be put in the comfy chair!

@brandtbucher
Copy link
Member

See #103909 for comparison.

@hauntsaninja hauntsaninja deleted the gh-103906 branch April 27, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants