Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-89812: Clean up pathlib tests. #104829

Merged
merged 4 commits into from
Jun 14, 2023
Merged

GH-89812: Clean up pathlib tests. #104829

merged 4 commits into from
Jun 14, 2023
+96 −84

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented May 24, 2023 •
edited by bedevere-bot
Loading

Merge PurePathTest into _BasePurePathTest, and PathTest into _BasePathTest. No change of coverage.

@barneygale
Clean up pathlib tests.
30ae2ed 
Merge `PurePathTest` into `_BasePurePathTest`, and `PathTest` into
`_BasePathTest`.
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels May 24, 2023
@barneygale barneygale mentioned this pull request May 24, 2023
Closed
@barneygale
Copy link
Contributor Author

Note that the _BasePurePathTest and _BasePathTest classes reflect a time long ago when pathlib had pathlib._BasePurePath and pathlib._BasePath classes. These haven't existed since pathlib was an independent package. We may re-introduce them in future (see #104810), but they will look rather different!

@barneygale barneygale changed the title Clean up pathlib tests. GH-89812: Clean up pathlib tests. Jun 3, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 3, 2023
Open
@ambv
Copy link
Contributor

ambv commented Jun 13, 2023

This depends on GH-105744.

@barneygale barneygale requested a review from ambv June 13, 2023 20:45
@ambv
Copy link
Contributor

ambv commented Jun 14, 2023

I currently don't have a Windows box to test the coverage with, but I tested on macOS and Linux and this looks good to me. Let's go for it! Thanks for the cleanup, Barney! ✨ 🍰 ✨

@ambv ambv merged commit dab5a3e into python:main Jun 14, 2023
@ambv
Copy link
Contributor

ambv commented Jun 14, 2023

(If you're curious to check on Windows, the guide is good: https://devguide.python.org/testing/coverage/)

@barneygale
Copy link
Contributor Author

Thank you for the review, Łukasz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv Awaiting requested review from ambv

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir topic-pathlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barneygale @ambv @bedevere-bot