Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106320: Fix specialize.c compilation by including pycore_pylifecycle.h #106434

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Jul 4, 2023

Compilation of Python/specialize.c was broken on macOS for me by gh-106400:

Python/specialize.c:233:9: error: call to undeclared function '_PyOS_URandomNonblock'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        _PyOS_URandomNonblock(rand, 20);
        ^
1 error generated.

@gvanrossum gvanrossum requested a review from vstinner July 4, 2023 21:17
@gvanrossum gvanrossum enabled auto-merge (squash) July 4, 2023 21:18
@gvanrossum gvanrossum merged commit 17af982 into python:main Jul 4, 2023
16 checks passed
@vstinner
Copy link
Member

vstinner commented Jul 4, 2023

Oh. Thanks for the fix, I didn't see this compiler warning/error on CIs.

@gvanrossum gvanrossum deleted the fix-specialize branch July 4, 2023 21:46
carljm added a commit to carljm/cpython that referenced this pull request Jul 5, 2023
* main: (39 commits)
  pythongh-102542 Remove unused bytes object and bytes slicing (python#106433)
  Clarify state of CancelledError in doc (python#106453)
  pythongh-64595: Fix regression in file write logic in Argument Clinic (python#106449)
  pythongh-104683: Rename Lib/test/clinic.test as Lib/test/clinic.test.c (python#106443)
  tp_flags docs: fix indentation (python#106420)
  pythongh-104050: Partially annotate Argument Clinic CLanguage class (python#106437)
  pythongh-106368: Add tests for formatting helpers in Argument Clinic (python#106415)
  pythongh-104050: Annotate Argument Clinic parameter permutation helpers (python#106431)
  pythongh-104050: Annotate toplevel functions in clinic.py (python#106435)
  pythongh-106320: Fix specialize.c compilation by including pycore_pylifecycle.h (python#106434)
  Add some codeowners for `Tools/clinic/` (python#106430)
  pythongh-106217: Truncate the issue body size of `new-bugs-announce-notifier` (python#106423)
  pythongh-61215: Rename `wait_until_any_call` to `wait_until_any_call_with` (python#106414)
  pythongh-106162: array: suppress warning in test_array (python#106404)
  pythongh-106320: Remove _PyInterpreterState_HasFeature() (python#106425)
  pythonGH-106360: Support very basic superblock introspection (python#106422)
  pythongh-106406: Fix _Py_IsInterpreterFinalizing() in _winapi.c (python#106408)
  pythongh-106396: Special-case empty format spec to gen empty JoinedStr node (python#106401)
  pythongh-106368: Add tests for permutation helpers in Argument Clinic (python#106407)
  pythonGH-106008: Fix refleak when peepholing `None` comparisons (python#106367)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants