Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-104584: Handle EXTENDED_ARG in superblock creation #106489

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Jul 6, 2023

Also fixed and cleaned up test_capi.test_misc.TestUops, and added a new test proving that EXTENDED_ARG works.

@gvanrossum
Copy link
Member Author

gvanrossum commented Jul 6, 2023

Tests are failing. I'll regroup and see if my EXTENDED_ARG handling is at fault or if it was pre-existing, and then proceed from there. For now, this is another Draft PR, and I'll isolate my test cleanups in a new PR.


UPDATE: Fixed by gh-106492, rebased, undrafted.

@gvanrossum gvanrossum marked this pull request as draft July 6, 2023 20:42
@gvanrossum
Copy link
Member Author

gvanrossum commented Jul 6, 2023

I get the same failure with just Fix and clean up uops and executor API. That makes me think the root problem is pre-existing (since that commit has no C code). I'll see if the address sanitizer will help me debug this.


UPDATE: Yeah, the UOpOptimizer type was missing a tp_dealloc handler. Nasty. Fixing that in gh-106492. Once that's merged I'll rebase and undraft this.

@gvanrossum gvanrossum marked this pull request as ready for review July 6, 2023 22:51
@gvanrossum gvanrossum merged commit e1d45b8 into python:main Jul 6, 2023
16 checks passed
@gvanrossum gvanrossum deleted the uops-extended-arg branch July 6, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants