Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-104584: Miscellaneous fixes for -Xuops #106908

Merged
merged 6 commits into from
Jul 20, 2023

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Jul 20, 2023

This fixes all of the tests that fail with the optimizer on.

By file:

  • Lib/dis.py: Teach dis how to parse bytecode containing ENTER_EXECUTOR or INSTRUMENTED_* instructions (by parsing the original code string instead and swapping in the adaptive opcodes at the last minute).
    • Fixes test_dis.
  • Lib/test/test_capi/test_misc.py and Lib/test_dis.py: Modify the tests' expected behavior when an optimizer is active.
    • Fixes test_dis and test_capi.
  • Python/bytecodes.c, Python/generated_cases.c.h, and Python/optimizer.c: Don't run the optimizer on instrumented back-edges.
    • Fixes test_monitoring, test_sys_settrace, and test_trace.
  • Python/executor_cases.c.h and Tools/cases_generator/generate_cases.py: Check the eval breaker when interpreting uops to avoid infinite closed loops.
    • Fixes test_gdb and test_os.
  • Python/pylifecycle.c: Fix refleak when installing optimizer.
    • Fixes test_embed.

@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 20, 2023
@brandtbucher brandtbucher self-assigned this Jul 20, 2023
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!!!

Python/bytecodes.c Show resolved Hide resolved
@brandtbucher brandtbucher enabled auto-merge (squash) July 20, 2023 16:13
@brandtbucher brandtbucher merged commit 214a25d into python:main Jul 20, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants