Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105699: Use a _Py_hashtable_t for the PyModuleDef Cache #106974

Merged
merged 14 commits into from
Jul 28, 2023
Merged

gh-105699: Use a _Py_hashtable_t for the PyModuleDef Cache #106974

merged 14 commits into from
Jul 28, 2023

Commits on Jul 21, 2023

  1. Add a comment.

    @ericsnowcurrently
    ericsnowcurrently committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    3397777 View commit details
    Browse the repository at this point in the history

  2. Add a TODO.

    @ericsnowcurrently
    ericsnowcurrently committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    670e632 View commit details
    Browse the repository at this point in the history

  3. Use a low-level hashtable instead of a dict.

    @ericsnowcurrently
    ericsnowcurrently committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    485d130 View commit details
    Browse the repository at this point in the history

  4. Drop _PyThreadState_*Detached().

    @ericsnowcurrently
    ericsnowcurrently committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    77d5e8f View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Set "byname" properly for the reload case.

    @ericsnowcurrently
    ericsnowcurrently committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    04a19c4 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Use a flat hashtable instead of a nested one.

    @ericsnowcurrently
    ericsnowcurrently committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    5fde127 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-extensions-tstate-alt

    @ericsnowcurrently
    ericsnowcurrently committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    818d828 View commit details
    Browse the repository at this point in the history

  3. Use the right allocator.

    @ericsnowcurrently
    ericsnowcurrently committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e83b0cc View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Use PyUnicode_AsUTF8AndSize() (and fix the assert). 

    Co-authored-by: T. Wouters <thomas@python.org>
    @ericsnowcurrently @Yhg1s
    ericsnowcurrently and Yhg1s committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    9e81cd5 View commit details
    Browse the repository at this point in the history

  2. Raise MemoryError where appropriate.

    @ericsnowcurrently
    ericsnowcurrently committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    430716b View commit details
    Browse the repository at this point in the history

  3. Add a comment.

    @ericsnowcurrently
    ericsnowcurrently committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    647fbc2 View commit details
    Browse the repository at this point in the history

  4. Use a constant for the cache separator character.

    @ericsnowcurrently
    ericsnowcurrently committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    bbe5eda View commit details
    Browse the repository at this point in the history

  5. Decref when clearing the hashtable.

    @ericsnowcurrently
    ericsnowcurrently committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    1d7cbd0 View commit details
    Browse the repository at this point in the history

  6. Make the cached module defs immortal.

    @ericsnowcurrently
    ericsnowcurrently committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    20c8b9d View commit details
    Browse the repository at this point in the history