Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106320: Remove private _PyList function #108451

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Aug 24, 2023

Move private functions to the internal C API (pycore_list.h):

  • _PyList_Extend()
  • _PyList_DebugMallocStats()

No longer export these functions.

Move private functions to the internal C API (pycore_list.h):

* _PyList_Extend()
* _PyList_DebugMallocStats()

No longer export these functions.
@vstinner vstinner enabled auto-merge (squash) August 24, 2023 19:21
@vstinner vstinner merged commit c3d580b into python:main Aug 24, 2023
22 checks passed
@vstinner vstinner deleted the pycore_list branch August 24, 2023 23:23
@scoder
Copy link
Contributor

scoder commented Oct 20, 2023

What is the intended replacement for _PyList_Extend() ?
Admittedly, there are several alternatives, so this is not a required part of the C-API. The function was just nice to have.

@vstinner
Copy link
Member Author

What is the intended replacement for _PyList_Extend() ?

I created issue gh-111138 to discuss it.

musicinmybrain added a commit to musicinmybrain/pyrsistent that referenced this pull request Oct 26, 2023
This private function is no longer exported in Python 3.13.

It is possible that a PyList_Extend() function-like macro may be added
before Python 3.13 final, but using PyList_SetSlice() directly will
still work.

python/cpython#108451

python/cpython#111138
musicinmybrain added a commit to musicinmybrain/pyrsistent that referenced this pull request Oct 26, 2023
This private function is no longer exported in Python 3.13.

It is possible that a PyList_Extend() function-like macro may be added
before Python 3.13 final, but using PyList_SetSlice() directly will
still work.

python/cpython#108451

python/cpython#111138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants