Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-99242 Ignore error when running regression tests under certain conditions. #121663

Conversation

basbloemsaat
Copy link
Contributor

@basbloemsaat basbloemsaat commented Jul 13, 2024

This is a port of #106705 to the current codebase.

PR made at EuroPython's sprint

Copy link

cpython-cla-bot bot commented Jul 13, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@encukou encukou merged commit 0759cec into python:main Jul 13, 2024
42 checks passed
@encukou encukou added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jul 13, 2024
@miss-islington-app
Copy link

Thanks @basbloemsaat for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks @basbloemsaat for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2024
…in conditions. (pythonGH-121663)

(cherry picked from commit 0759cec)

Co-authored-by: Bas Bloemsaat <bas@bloemsaat.com>
Co-Authored-By: Kevin Diem <kg.diem@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 13, 2024

GH-121669 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 13, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2024
…in conditions. (pythonGH-121663)

(cherry picked from commit 0759cec)

Co-authored-by: Bas Bloemsaat <bas@bloemsaat.com>
Co-Authored-By: Kevin Diem <kg.diem@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 13, 2024

GH-121670 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jul 13, 2024
@basbloemsaat basbloemsaat deleted the fix-issue-99242-Ignore-load-averages-if-getloadavg-is-unavailable branch July 13, 2024 09:54
encukou pushed a commit that referenced this pull request Jul 13, 2024
…ain conditions. (GH-121663) (GH-121670)

gh-99242 Ignore error when running regression tests under certain conditions. (GH-121663)
(cherry picked from commit 0759cec)

Co-authored-by: Bas Bloemsaat <bas@bloemsaat.com>
Co-authored-by: Kevin Diem <kg.diem@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…in conditions. (pythonGH-121663)

Co-Authored-By: Kevin Diem <kg.diem@gmail.com>
encukou pushed a commit that referenced this pull request Jul 22, 2024
…ain conditions. (GH-121663) (GH-121669)

(cherry picked from commit 0759cec)

Co-authored-by: Bas Bloemsaat <bas@bloemsaat.com>
Co-authored-by: Kevin Diem <kg.diem@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora LTO + PGO 3.13 has failed when building commit f00ba73.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1511/builds/229) and take a look at the build logs.
  4. Check if the failure is related to this commit (f00ba73) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1511/builds/229

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_inspect_keeps_globals_from_inspected_file - test.test_pyrepl.test_pyrepl.TestMain.test_inspect_keeps_globals_from_inspected_file

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z.lto-pgo/build/Lib/test/test_pyrepl/test_pyrepl.py", line 995, in _run_repl_globals_test
    self.fail(f"{var}= not found in output")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: __package__= not found in output


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z.lto-pgo/build/Lib/test/test_pyrepl/test_pyrepl.py", line 995, in _run_repl_globals_test
    self.fail(f"{var}= not found in output")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: __name__= not found in output


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z.lto-pgo/build/Lib/test/test_pyrepl/test_pyrepl.py", line 995, in _run_repl_globals_test
    self.fail(f"{var}= not found in output")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: FOO= not found in output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants