Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Ruff to 0.6.7 #124384

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Bump Ruff to 0.6.7 #124384

merged 1 commit into from
Sep 23, 2024

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Sep 23, 2024

This bump requires the addition of three noqa: F811 comments. Two of these (the ones in Lib/test/pickletester.py and Lib/test/test_with.py) are somewhat unavoidable, as Ruff is working as intended. The noqa added in Lib/test/test_os.py indicates a bug in Ruff, however; I'll follow up on this and hopefully fix it.

As well as the F811-related changes, there's also a small simplification made to Doc/tools/extensions/c_annotations.py, to address a new FURB188 diagnostic in that file.


📚 Documentation preview 📚: https://cpython-previews--124384.org.readthedocs.build/

if name.startswith("c."):
name = name[2:]

name = par[0]["ids"][0].removeprefix("c.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little cleanup :)

@AlexWaygood AlexWaygood enabled auto-merge (squash) September 23, 2024 22:02
@AlexWaygood AlexWaygood added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Sep 23, 2024
@AlexWaygood AlexWaygood merged commit 8a2baed into python:main Sep 23, 2024
42 checks passed
@AlexWaygood AlexWaygood deleted the bump-ruff branch September 23, 2024 22:19
@miss-islington-app
Copy link

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @AlexWaygood, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8a2baedc4bcb606da937e4e066b4b3a18961cace 3.13

@miss-islington-app
Copy link

Sorry, @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8a2baedc4bcb606da937e4e066b4b3a18961cace 3.12

AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Sep 23, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 23, 2024

GH-124389 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 23, 2024
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Sep 23, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 23, 2024

GH-124391 is a backport of this pull request to the 3.12 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants