Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-20039: Add doc to argparse.ArgumentTypeError #31125

Closed
wants to merge 3 commits into from
Closed

bpo-20039: Add doc to argparse.ArgumentTypeError #31125

wants to merge 3 commits into from

Conversation

ukarroum
Copy link
Contributor

@ukarroum ukarroum commented Feb 4, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Feb 4, 2022
@arnaut-billings arnaut-billings mannequin mentioned this pull request Apr 10, 2022
Closed
MaxwellDupre
MaxwellDupre approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this adds value.

nanjekyejoannah
nanjekyejoannah reviewed Oct 7, 2022
View reviewed changes
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so do we need to document ArgumentError as well too?

slateny
slateny reviewed Jan 11, 2023
View reviewed changes
Doc/library/argparse.rst Outdated
.. exception:: ArgumentTypeError

An error from trying to convert a command line string to a type

.. versionadded:: 3.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be above the 'Exceptions' header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ukarroum
Copy link
Contributor Author

Looks like this issue was already solved in this commit: 79ae019
closing the pull request

@ukarroum ukarroum closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah left review comments

@slateny slateny slateny left review comments

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

Assignees
No one assigned
Labels
awaiting core review docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ukarroum @MaxwellDupre @nanjekyejoannah @slateny @hugovk @the-knights-who-say-ni @ezio-melotti @bedevere-bot