Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-87092: compiler's codegen stage uses int jump target labels, and the target pointer is only calculated just before optimization stage #95655

Merged
merged 7 commits into from
Aug 11, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 4, 2022

@iritkatriel iritkatriel changed the title gh-87092: In compiler's codeine: change jump_target_label to int and store it in i_oparg gh-87092: In compiler's codegen stage: change jump_target_label to int and store it in i_oparg Aug 4, 2022
@iritkatriel
Copy link
Member Author

Skipping news because this continues the work described in the news entry on #95398.

@iritkatriel iritkatriel added interpreter-core (Objects, Python, Grammar, and Parser dirs) 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Aug 4, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit cdde94f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 4, 2022
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 10, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit bb16973 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 10, 2022
@iritkatriel iritkatriel self-assigned this Aug 10, 2022
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 11, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 8a57c23 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 11, 2022
@iritkatriel iritkatriel changed the title gh-87092: In compiler's codegen stage: change jump_target_label to int and store it in i_oparg gh-87092: compiler's codegen stage uses int labels, target pointer only calculated just before optimization stage Aug 11, 2022
@iritkatriel iritkatriel changed the title gh-87092: compiler's codegen stage uses int labels, target pointer only calculated just before optimization stage gh-87092: compiler's codegen stage uses int jump target labels, and the target pointer is only calculated just before optimization stage Aug 11, 2022
@iritkatriel
Copy link
Member Author

The FreeBsd timeout seems unrelated - it's doing that on other PRs.

This is ready to be reviewed now. With this I can write the unit tests without needing the test harness to worry about blocks.

Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, otherwise LGTM.

Python/compile.c Outdated Show resolved Hide resolved
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iritkatriel iritkatriel merged commit 9533b40 into python:main Aug 11, 2022
@iritkatriel iritkatriel deleted the codegen-labels-cont branch September 29, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants