GH-98539: fix ref cycle in _SSLProtocolTransport after close
#98540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
force-pushed
the
ssl-fix
branch
from
7cbbcf4
to
39a0df2
Compare
kumaraditya303
requested review from
1st1,
asvetlov and
gvanrossum
as code owners
gvanrossum
reviewed
Oct 22, 2022
gvanrossum
approved these changes
Oct 22, 2022
|
Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 22, 2022
…ythonGH-98540) (cherry picked from commit 62bf5d8) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
|
GH-98551 is a backport of this pull request to the 3.11 branch. |
pquentin
added a commit
to pquentin/rally
that referenced
this pull request
May 4, 2023
Since python/cpython#98540 which was included in Python 3.11.1, aiohttp can fail if two tasks are trying to close the connection concurrently.
This was referenced May 4, 2023
1 task
bdraco
added a commit
to home-assistant/core
that referenced
this pull request
May 13, 2023
There is currently a relatively fast memory leak when using cpython 3.11.2+ and cleanup_closed with aiohttp For my production instance it was leaking ~450MiB per day of `MemoryBIO`, `SSLProtocol`, `SSLObject`, `_SSLProtocolTransport` `memoryview`, and `managedbuffer` objects see aio-libs/aiohttp#7252 see python/cpython#98540
Merged
20 tasks
|
This change makes it unsafe to call |
Makes sense. Can you send a PR? |
balloob
pushed a commit
to home-assistant/core
that referenced
this pull request
May 14, 2023
…93013) * Disable cleanup_closed for aiohttp.TCPConnector with cpython 3.11.2+ There is currently a relatively fast memory leak when using cpython 3.11.2+ and cleanup_closed with aiohttp For my production instance it was leaking ~450MiB per day of `MemoryBIO`, `SSLProtocol`, `SSLObject`, `_SSLProtocolTransport` `memoryview`, and `managedbuffer` objects see aio-libs/aiohttp#7252 see python/cpython#98540 * Update homeassistant/helpers/aiohttp_client.py
balloob
pushed a commit
to home-assistant/core
that referenced
this pull request
May 14, 2023
…93013) * Disable cleanup_closed for aiohttp.TCPConnector with cpython 3.11.2+ There is currently a relatively fast memory leak when using cpython 3.11.2+ and cleanup_closed with aiohttp For my production instance it was leaking ~450MiB per day of `MemoryBIO`, `SSLProtocol`, `SSLObject`, `_SSLProtocolTransport` `memoryview`, and `managedbuffer` objects see aio-libs/aiohttp#7252 see python/cpython#98540 * Update homeassistant/helpers/aiohttp_client.py
teharris1
pushed a commit
to teharris1/home-assistant
that referenced
this pull request
May 23, 2023
…ome-assistant#93013) * Disable cleanup_closed for aiohttp.TCPConnector with cpython 3.11.2+ There is currently a relatively fast memory leak when using cpython 3.11.2+ and cleanup_closed with aiohttp For my production instance it was leaking ~450MiB per day of `MemoryBIO`, `SSLProtocol`, `SSLObject`, `_SSLProtocolTransport` `memoryview`, and `managedbuffer` objects see aio-libs/aiohttp#7252 see python/cpython#98540 * Update homeassistant/helpers/aiohttp_client.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_SSLProtocolTransportkeeps reference to protocol after close #98539