Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Imporves __div__ with __future__ import on py2 (#11276)" #11741

Merged
merged 1 commit into from
Dec 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions mypy/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -2188,11 +2188,8 @@ def type_checker(self) -> TypeChecker:
if not self._type_checker:
assert self.tree is not None, "Internal error: must be called on parsed file only"
manager = self.manager
self._type_checker = TypeChecker(
manager.errors, manager.modules, self.options,
self.tree, self.xpath, manager.plugin,
self.manager.semantic_analyzer.future_import_flags,
)
self._type_checker = TypeChecker(manager.errors, manager.modules, self.options,
self.tree, self.xpath, manager.plugin)
return self._type_checker

def type_map(self) -> Dict[Expression, Type]:
Expand Down
8 changes: 1 addition & 7 deletions mypy/checker.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,12 +221,8 @@ class TypeChecker(NodeVisitor[None], CheckerPluginInterface):
# functions such as open(), etc.
plugin: Plugin

# Future flags that we get from semantic analyzer.
future_import_flags: Set[str]

def __init__(self, errors: Errors, modules: Dict[str, MypyFile], options: Options,
tree: MypyFile, path: str, plugin: Plugin,
future_import_flags: Set[str]) -> None:
tree: MypyFile, path: str, plugin: Plugin) -> None:
"""Construct a type checker.

Use errors to report type check errors.
Expand Down Expand Up @@ -272,8 +268,6 @@ def __init__(self, errors: Errors, modules: Dict[str, MypyFile], options: Option
# argument through various `checker` and `checkmember` functions.
self._is_final_def = False

self.future_import_flags = future_import_flags

@property
def type_context(self) -> List[Optional[Type]]:
return self.expr_checker.type_context
Expand Down
3 changes: 2 additions & 1 deletion mypy/checkexpr.py
Original file line number Diff line number Diff line change
Expand Up @@ -2414,7 +2414,8 @@ def dangerous_comparison(self, left: Type, right: Type,

def get_operator_method(self, op: str) -> str:
if op == '/' and self.chk.options.python_version[0] == 2:
return '__truediv__' if 'division' in self.chk.future_import_flags else '__div__'
# TODO also check for "from __future__ import division"
return '__div__'
else:
return operators.op_methods[op]

Expand Down
26 changes: 0 additions & 26 deletions test-data/unit/check-expressions.test
Original file line number Diff line number Diff line change
Expand Up @@ -202,32 +202,6 @@ class C:
pass
[builtins fixtures/tuple.pyi]

[case testDivPython2]
# flags: --python-version 2.7
class A(object):
def __div__(self, other):
# type: (A, str) -> str
return 'a'

a = A()
reveal_type(a / 'b') # N: Revealed type is "builtins.str"
a / 1 # E: Unsupported operand types for / ("A" and "int")
[builtins fixtures/bool.pyi]

[case testDivPython2FutureImport]
# flags: --python-version 2.7
from __future__ import division

class A(object):
def __truediv__(self, other):
# type: (A, str) -> str
return 'a'

a = A()
reveal_type(a / 'b') # N: Revealed type is "builtins.str"
a / 1 # E: Unsupported operand types for / ("A" and "int")
[builtins fixtures/bool.pyi]

[case testIntDiv]
a, b, c = None, None, None # type: (A, B, C)
if int():
Expand Down