Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Literal type math #11992

Closed
wants to merge 3 commits into from
Closed

Adds Literal type math #11992

wants to merge 3 commits into from

Conversation

sobolevn
Copy link
Member

Refs #11990

@github-actions

This comment has been minimized.

@sobolevn
Copy link
Member Author

CC @hauntsaninja @JukkaL

@@ -246,3 +248,66 @@ def visit_temp_node(self, e: TempNode) -> None:


_hasher: Final = _Hasher()


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name literal of this literals.py file is different from the Literal in typing, which is an old and annoying conflict. I am not sure whether they should put in same file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the old and new functionality are quite distinct, so having in the same file could be confusing. One option would be to move the old code into a new module with a different name.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JukkaL Any suggestions on the new name for the old part?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps simple_expr.py? Or even literal_expr.py, though I don't think that helps much.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants