Warn on module level type ignore with error code #13512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per-module error codes were added in #13502, let's recommend using them.
The existing type ignore behaviour is pretty unintuitive; I think most
people actually want
# mypy: ignore-errors
. There are probably peopledepending on the current behaviour of
# type: ignore
though.Fixes #13435, fixes #12076, fixes #11999, fixes #11027, fixes #9318,
fixes #7839